So I want to buy an Mp3 Player

[MetalMilitia]

I've got a Samsung YP-Z5 and it's a solid player. It only comes in 2GB and 4GB flavors which are small if you have a large music collection but if you don't mind swapping albums around frequently it's not a big problem. Battery life is good and it has a swish interface.

It's hard to recommend though as it's a bit overpriced. I only really bought it out of brand loyalty and this might have been a bad decision considering how much more space you can get on similarly priced players.